[9.x] Add SeeInOrder Mailable assertions #40460
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm adding
assertSeeInOrderText
andassertSeeInOrderHtml
to the Mailable class to compliment the other test assertions already present. They work similarly to theassertSeeInOrder
available on\Illuminate\Testing\TestResponse
and use the same PHPUnit constraint.This is useful for testing that your mail is displaying items in the order you would expect.
For instance for view
and Mailable
You would be able to test if the list was in order with
While trying to add tests for this assertion, I realized that none of the existing Mailable assertions were tested. I created
MailMailableAssertionsTest
to test the existing assertions and my new ones.I found
renderForAssertions
pretty hard to mock out without a good example, so I just overrode it with the expected in the test. I thought this was at least better than no the current state of no tests. However, I could remove the tests from this PR if that is better, or spend some more time mocking it further from the tests if someone could point me in the right direction.