[9.x] Improve types on model factory methods#40902
Merged
nunomaduro merged 2 commits intolaravel:9.xfrom Feb 10, 2022
axlon:patch-3
Merged
[9.x] Improve types on model factory methods#40902nunomaduro merged 2 commits intolaravel:9.xfrom axlon:patch-3
nunomaduro merged 2 commits intolaravel:9.xfrom
axlon:patch-3
Conversation
Member
|
Can you add a few tests on |
Contributor
Author
|
@nunomaduro I added the additional type checks, I noticed that PHPStan will always report the parameters of callables that are parameters themselves as Either way this PR should solve a few cases where callables were previously not allowed, or were only allowed without parameters. |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the following PHPStan error found in the application boilerplate (tested at level 8):
I also updated the types for
create,createOne,createQuietly,make,makeOne,rawandnew. I wanted to updatelazyas well but its currently hardcoded as an array