[9.x] Fake Temporary URLs#41113
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, when you call
Storage::fake, an actual "local" disk is created and mounted to a temporary location. However, the local disk does not support calls totemporaryUrl, and will receive errors if your code invokes this method during the test.This uses the
buildTemporaryUrlsUsingmethod to register a custom callback that just returns the path given as a URL with the expiration in the query string. Obviously, this does not point to a real file; however, this allows the code to execute and get a valid string back from this method that should be satisfactory for testing purposes.