[9x] Remove redundant check in FormRequest::validated()

[fabio-ivona]

Hi!

this PR aims to remove a redundant check in Illuminate\Foundation\Http\FormRequest:

// Illuminate\Foundation\Http\FormRequest lines 213-222

public function validated($key = null, $default = null)
{
    if (! is_null($key)) {
        return data_get(
            $this->validator->validated(), $key, $default
        );
    }

    return $this->validator->validated();
}

the !is_null is used to return the entire validated set if a $key is not provided

but the same check is done inside the data_get() helper:

// Illuminate\Collections\helpers.php lines 46-49

function data_get($target, $key, $default = null)
{
    if (is_null($key)) {
        return $target;
    }
    //...
}

so it can be safely removed and the code can be made simpler

note the same optimization can be done in master, will open a new PR for it if this gets approved

[driesvints]

@fabio-ivona 9.x is merged into master so no need for a separate PR 👍

[fabio-ivona]

@driesvints my fault, thinking that master was already set up for v10 👼

[driesvints]

@fabio-ivona it is indeed set up for v10.

[fabio-ivona]

ok now I got it 👍