Skip to content

[9.x] remove useless if statement from SupportReflectorTest #41578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 20, 2022
Merged

[9.x] remove useless if statement from SupportReflectorTest #41578

merged 1 commit into from
Mar 20, 2022

Conversation

hAz5
Copy link
Contributor

@hAz5 hAz5 commented Mar 20, 2022

because of Laravel9 min PHP requirement is 8 and above , this if statement is useless

if (PHP_MAJOR_VERSION >= 8) {
    eval('
namespace Illuminate\Tests\Support;

GrahamCampbell
GrahamCampbell requested changes Mar 20, 2022
View reviewed changes
@hAz5 hAz5 force-pushed the remove-useless-if branch from a030421 to 3daabbd Compare March 20, 2022 11:12
@driesvints driesvints merged commit ba14364 into laravel:9.x Mar 20, 2022
@driesvints
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GrahamCampbell GrahamCampbell GrahamCampbell requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hAz5 @driesvints @GrahamCampbell