Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[9.x] Fixes memory leak on TestCase handlers #44307

Merged
merged 1 commit into from
Sep 26, 2022

Conversation

nunomaduro
Copy link
Member

This pull request addresses one of the memory leaks being mentioned at #44214, by performing a proper cleaning of the $originalExceptionHandler and $originalDeprecationHandler on the Laravel's base test case class.

On Vapor's test suite, after having #44306 (33% less memory), and after disabling bugsnag (14% less memory) - here is the results on 600 tests: 1% less memory used.

Before…
Time: 01:02.732, Memory: 168.50 MB

After…
Time: 01:02.595, Memory: 166.50 MB

@taylorotwell taylorotwell merged commit e6f0ba3 into 9.x Sep 26, 2022
@taylorotwell taylorotwell deleted the fix/memory-leaks-in-test-suite-handlers branch September 26, 2022 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants