[9.x] Passthrough PATH variable to serve command#45402
Merged
taylorotwell merged 2 commits intolaravel:9.xfrom Dec 23, 2022
buismaarten:patch-1
Merged
[9.x] Passthrough PATH variable to serve command#45402taylorotwell merged 2 commits intolaravel:9.xfrom buismaarten:patch-1
PATH variable to serve command#45402taylorotwell merged 2 commits intolaravel:9.xfrom
buismaarten:patch-1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm setting up the
spatie/dnspackage inside a Laravel Sail container. It uses theExecutableFinderclass of the Symfony Process component that uses thePATHenvironment variable to search thedigexecutable.This change fixes the issue by passing the environment variable using the
artisan servecommand that Laravel Sail uses. See: https://github.com/laravel/sail/blob/122af16408841cc750095a4ca3193751eed3f673/runtimes/8.1/supervisord.conf#L8Edit:
All environment variables are passed through when
artisan serve --no-reloadis used, but this would not be a ideal solution.