[9.x] fixed issue on which class to check increment and decrement methods for custom cast

[WendellAdriel]

This fix is related to the issue mentioned on #45418
The code was checking if the increment/decrement methods were available on one class but then using another class to actually call the methods. This fix is for the code to check the same class that will be called the methods.

[Sjord]

Wouldn't it be better to just call the existing resolveCasterClass method?

[WendellAdriel]

I see your point @Sjord

But the resolveCasterClass will resolve the class while in the code I wrote it's going to only check if the castUsing is present and get the class from it without creating an instance of the class.

I'm fine with both solutions tho. I'll just wait for someone to review it and if needed I can update it.
Thanks for the help 😉

[taylorotwell]

I think a test would be good here.

[sumihiran]

Wouldn't calling the "castUsing" method with an empty array disregards any given cast parameters?

[WendellAdriel]

@taylorotwell I'll work on the test
@sumihiran I'm going to check your observation

[WendellAdriel]

@taylorotwell I made some changes:

• Added a test case following the example given on Increment on a field with custom cast checks for method on one class but calls another #45418
• Changed the isClassDeviable to use the resolveCasterClass method because of the observation made by @sumihiran