[10.x] make dispatch() behaviour same across the framework

[ankurk91]

Fixes the bug #45781

The dispatch method inside DispatchesJobs trait does not check for Unique Jobs.

The global dispatch helper functions does check it here

framework/src/Illuminate/Foundation/Bus/PendingDispatch.php

Line 163 in f801dd7

return (new UniqueLock(Container::getInstance()->make(Cache::class)))

This PR make these 2 methods act same.

[driesvints]

This is a big change in behavior as you're now using the job itself to dispatch and not the dispatcher.

[ankurk91]

@driesvints

The global helper method is not using the Dispatcher already.
and The PendingDispatch class is using the Dispatcher internally.
The only difference is to check for Unique jobs.

If you don't like this big change then,
The the dispatch method available to all Controllers via DispatchesJobs Trait must be renamed to forceDispatch() instead.

PS.
Laravel is known for DX and developer happiness. :)
This big change can save several debugging hours.

I would like to hear from other Laravel Team members.

[taylorotwell]

Fine with this change but IMO we should probably just remove this trait from the base controller in Laravel 10. It isn't necessary at all.

[ankurk91]

Thanks Taylor,❤️
i will send a PR for the same

[driesvints]

Thanks @ankurk91

[browner12]

For reference: laravel/laravel@f62d260