Bug ShowModelCommand not guessing policy #47043
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jessarcher
reviewed
May 12, 2023
Co-authored-by: Jess Archer <jess@jessarcher.com>
milwad-dev
pushed a commit
to milwad-dev/framework
that referenced
this pull request
May 12, 2023
* Fix: ShowModelCommand not guessing policy * fix style * Update src/Illuminate/Database/Console/ShowModelCommand.php Co-authored-by: Jess Archer <jess@jessarcher.com> --------- Co-authored-by: Deniss Levskoi <deniss@oops.ee> Co-authored-by: Taylor Otwell <taylor@laravel.com> Co-authored-by: Jess Archer <jess@jessarcher.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the command defines it`s own method for resolving policies, which does not take into account the Policy guessing feature of Laravel. I suggest we reuse Gate own method for this.