Skip to content

[10.x] Fix return type of prefixedResource & prefixedResource #47445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 15, 2023
Merged

[10.x] Fix return type of prefixedResource & prefixedResource #47445

merged 2 commits into from
Jun 15, 2023

Conversation

milwad-dev
Copy link
Contributor

@milwad-dev milwad-dev commented Jun 15, 2023 •
edited
Loading

Both functions return Router but in phpdoc, it returns void!

driesvints
driesvints requested changes Jun 15, 2023
View reviewed changes
@driesvints driesvints marked this pull request as draft June 15, 2023 09:43
@milwad-dev milwad-dev requested a review from driesvints June 15, 2023 09:49
@driesvints driesvints marked this pull request as ready for review June 15, 2023 09:50
@driesvints driesvints removed their request for review June 15, 2023 09:50
@taylorotwell taylorotwell merged commit ea5172e into laravel:10.x Jun 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@driesvints driesvints driesvints requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@milwad-dev @driesvints @taylorotwell