New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[10.x] Fix flakey `HttpClientTest` test #48166

Merged

taylorotwell merged 1 commit into laravel:10.x from joshbonnick:patch-1

Aug 25, 2023

Contributor

joshbonnick commented Aug 24, 2023

Similar to #48156. This PR replaces the use of $startTime = microtime(true); with Sleep::fake().

The updated test in HttpClientTest was failing with the following:

Failed asserting that 0.33161306381225586 matches expected 0.3.

Expected: 0.3
Actual: 0.33161306381226


          Use the Sleep::fake feature instead of microtime

d01658e

taylorotwell merged commit 0a0c1de into laravel:10.x

20 checks passed

joshbonnick deleted the patch-1 branch

August 25, 2023 13:40

edcheyjr mentioned this pull request

Bump laravel/framework from 10.20.0 to 10.21.0 edcheyjr/notes-api#15

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment