Skip to content

[10.x] Improve naming #48413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 15, 2023
Merged

[10.x] Improve naming #48413

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/Illuminate/Foundation/Exceptions/Handler.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,11 +121,11 @@ class Handler implements ExceptionHandlerContract
];

/**
* Indicates that exception reporting should be deduplicated.
* Indicates that an exception instance should only be reported once.
*
* @var bool
*/
protected $deduplicateReporting = false;
protected $withoutDuplicates = false;

/**
* The already reported exception map.
Expand Down Expand Up @@ -326,7 +326,7 @@ public function shouldReport(Throwable $e)
*/
protected function shouldntReport(Throwable $e)
{
if ($this->deduplicateReporting && ($this->reportedExceptionMap[$e] ?? false)) {
if ($this->withoutDuplicates && ($this->reportedExceptionMap[$e] ?? false)) {
return true;
}

Expand Down Expand Up @@ -816,7 +816,7 @@ public function renderForConsole($output, Throwable $e)
*/
public function dontReportDuplicates()
{
$this->deduplicateReporting = true;
$this->withoutDuplicates = true;

return $this;
}
Expand Down