Skip to content

Conversation

bastiendonjon
Copy link
Contributor

Lets continue the process with only validated datas

Move commit on 4.2 branche : #4833

Lets continue the process with only validated datas

Move commit on 4.2 branche : laravel#4833
@lucasmichot
Copy link
Contributor

Duplicates #4826 ?

@bastiendonjon
Copy link
Contributor Author

No, your methods return keys validaded or failded. My method return keys and values validated.

@taylorotwell
Copy link
Member

Function should be named passed.

bastiendonjon added a commit to bastiendonjon/framework that referenced this pull request Jun 27, 2014
@taylorotwell
Copy link
Member

People will complain about this returning all attributes if validation has not run yet.

@bastiendonjon
Copy link
Contributor Author

ok how to detect if validation has run ?

@bastiendonjon
Copy link
Contributor Author

I done.

@bworwa
Copy link

bworwa commented Jul 4, 2014

Why would you return the validated values when you already know them?

@bastiendonjon
Copy link
Contributor Author

To ensure work with a table of expected and valid data. And avoid non-expected data ...

And remove a filtering step in the controller

@taylorotwell taylorotwell merged commit 84eacdb into laravel:4.2 Sep 12, 2014
@taylorotwell
Copy link
Member

Renamed this to valid and added invalid. We already had a method named failed which returned the rules that failed validation, so having a passed which returns the data would have been inconsistent and unintuitive.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants