Skip to content

[10.x] Account for new MariaDB platform#48563

Merged
taylorotwell merged 1 commit into
laravel:10.xfrom
timacdonald:maria-platform
Sep 27, 2023
Merged

[10.x] Account for new MariaDB platform#48563
taylorotwell merged 1 commit into
laravel:10.xfrom
timacdonald:maria-platform

Conversation

@timacdonald

@timacdonald timacdonald commented Sep 27, 2023

Copy link
Copy Markdown
Member

dbal introduced a new platform in 3.7.0 which our switch does not currently account for.

Hoping this fixes the currently failing framework tests.

Note: I have no idea about this part of the framework. Please, send help.

@taylorotwell
taylorotwell merged commit c78c5fd into laravel:10.x Sep 27, 2023
@timacdonald
timacdonald deleted the maria-platform branch September 27, 2023 03:43
@kamui545

kamui545 commented Oct 3, 2023

Copy link
Copy Markdown
Contributor

@timacdonald is the comma after MariaDb1052Platform::class really intended ? Sorry if it is, I am not that familiar with match.

@driesvints

Copy link
Copy Markdown
Member

@kamui545 it shouldn't be breaking. But don't think it's needed either.

@kamui545

kamui545 commented Oct 3, 2023

Copy link
Copy Markdown
Contributor

That's what I thought, thank you for confirming.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants