Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[10.x] Account for new MariaDB platform #48563

Merged
merged 1 commit into from Sep 27, 2023

Conversation

timacdonald
Copy link
Member

@timacdonald timacdonald commented Sep 27, 2023

dbal introduced a new platform in 3.7.0 which our switch does not currently account for.

Hoping this fixes the currently failing framework tests.

Note: I have no idea about this part of the framework. Please, send help.

@taylorotwell taylorotwell merged commit c78c5fd into laravel:10.x Sep 27, 2023
19 of 20 checks passed
@timacdonald timacdonald deleted the maria-platform branch September 27, 2023 03:43
@kamui545
Copy link
Contributor

kamui545 commented Oct 3, 2023

@timacdonald is the comma after MariaDb1052Platform::class really intended ? Sorry if it is, I am not that familiar with match.

@driesvints
Copy link
Member

@kamui545 it shouldn't be breaking. But don't think it's needed either.

@kamui545
Copy link
Contributor

kamui545 commented Oct 3, 2023

That's what I thought, thank you for confirming.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants