Skip to content

[10.x] Fix replaceMatches in Str class#48760

Merged
taylorotwell merged 1 commit into
laravel:10.xfrom
hosmelq:fix-replace-matches-in-str-class
Oct 18, 2023
Merged

[10.x] Fix replaceMatches in Str class#48760
taylorotwell merged 1 commit into
laravel:10.xfrom
hosmelq:fix-replace-matches-in-str-class

Conversation

@hosmelq

@hosmelq hosmelq commented Oct 18, 2023

Copy link
Copy Markdown
Contributor

This pull request resolves the previous issue with PR #48727, where the 'static' keyword was missing. I forgot to include it.

@hosmelq

hosmelq commented Oct 18, 2023

Copy link
Copy Markdown
Contributor Author

cc: @driesvints @taylorotwell

@mpyw mpyw left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@taylorotwell
taylorotwell merged commit 8d8d5f7 into laravel:10.x Oct 18, 2023
timacdonald pushed a commit to timacdonald/framework that referenced this pull request Oct 24, 2023
@hosmelq
hosmelq deleted the fix-replace-matches-in-str-class branch October 29, 2024 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants