[11.x] Allow Str::limit to include ellipsis in length calculation

[inxilpro]

Right now Str::limit() checks the limit before appending the $end (three dots, or a faux-ellipsis, by default) to the string. This can result in strings that are truncated and over the limit…

Before:

Str::limit('Hello world', 10);

// Results in "Hello worl..." which is 13 characters in total

This PR includes the length of the $end argument in the calculation:

After:

Str::limit('Hello world', 10);

// Results in "Hello w..." which is 10 characters in total, including the three dots

[inxilpro]

Also, I'm happy to change this to 10.x since it's barely a breaking change, but I PR'd against 11.x just to be safe.

[deleugpn]

Seems like the additional parameter is overly protective. Targeting 11.x, I would argue that adding an upgrade note that explains the change and suggests users that if they want the previous behavior they should increment the length by 3 characters or by the size of the $end parameter that they are passing.

Point being, this change as it currently stands is an opt-in change on a future major release. Given how small of a BC this is we could simplify by still targeting 11.x but making it opt-out instead by intructing users to change the limit size.

[inxilpro]

Point being, this change as it currently stands is an opt-in change on a future major release. Given how small of a BC this is we could simplify by still targeting 11.x but making it opt-out instead by intructing users to change the limit size.

Yeah, I was being very careful. But I tend to agree. I'll change it to the new default and see what happens :)

[taylorotwell]

Some of this behavior seems kinda weird? I think I will just stick with how it is.

Your PR:

Current behavior:

[inxilpro]

Haha, I did not account for negative overflow. I may re-open with that fixed…