[10.x] Fix type error registering PSR Request#48823
Merged
Merged
Conversation
kpicaza
force-pushed
the
10.x
branch
2 times, most recently
from
October 25, 2023 21:39
97a09bb to
c382d5e
Compare
timacdonald
marked this pull request as ready for review
October 25, 2023 22:38
timacdonald
approved these changes
Oct 25, 2023
timacdonald
left a comment
timacdonald
left a comment
Member
There was a problem hiding this comment.
Verified the type error fix but also that it was previously expecting to have an empty array as the parsed body and not null.
LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type error at Illuminate\Routing\RoutingServiceProvider::registerPsrRequest
Fixes #48822