Skip to content

[10.x] Fix empty request for HTTP connection exception #49924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 31, 2024

Conversation

driesvints
Copy link
Member

@driesvints driesvints commented Jan 31, 2024

In a situation where there's a connection exception happening before a request object has been attached to the PendingRequest, we can simply recreate the request object from the connection exception before sending the ConnectionFailed event.

Fixes #49909

@driesvints driesvints linked an issue Jan 31, 2024 that may be closed by this pull request
@driesvints driesvints changed the title Fix empty request for HTTP connection exception [10.x] Fix empty request for HTTP connection exception Jan 31, 2024
@taylorotwell taylorotwell merged commit 8206d96 into 10.x Jan 31, 2024
@taylorotwell taylorotwell deleted the fix-http-connection-exception branch January 31, 2024 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeError with HTTP Client
2 participants