Skip to content

Fix eager loading with groupBy and paginate #5072

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix eager loading with groupBy and paginate #5072

wants to merge 1 commit into from

Conversation

faytzel
Copy link

@faytzel faytzel commented Jul 15, 2014

See issue #5063

@faytzel faytzel mentioned this pull request Jul 15, 2014
Closed
@GrahamCampbell
Copy link
Member

This breakes the tests.

@faytzel
Copy link
Author

faytzel commented Jul 16, 2014

I did try to correct the issue following the tests and it didn't worked.
Finnally, I decided to use 2 SQLs in order to fix the problem.
The first SQLs get IDs and the second uses the eager loading with whereIn('id', $ids) method.

@faytzel faytzel closed this Jul 16, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@faytzel @GrahamCampbell