[11.x] Add assertJsonFragments assertion#54576
Merged
Merged
Conversation
cosmastech
reviewed
Feb 12, 2025
| * @param array $data | ||
| * @return $this | ||
| */ | ||
| public function assertJsonFragments(array $data) |
Contributor
There was a problem hiding this comment.
Just a quick thought: might be nice if this were variadic so a user could write:
$response->assertJsonFragments(
['current_page' => 2],
['per_page' => 25],
['total' => 26]
);
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Sometimes when asserting a JSON response, it can be helpful when you're looking for multiple fragments at once. A concrete example is when you want to assert some
metavalues regarding pagination.The current test looks like this;
Now the
metakey in the response will contain all of the pagination data but it's hard to prepare an assertion for that entire part of the response. Particularly, often you only want to assert a handful of the key/value pairs of the response.Solution
By adding the
assertJsonFragmentsmethod, it means you don't have to chain theassertJsonFragmentcalls;