[12.x] Refactor Notification Stubs: Decouple Queueable Trait into Queued-Specific Stubs #55978
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR proposes a refactor in how notification classes are scaffolded using the
make:notification
Artisan command.Currently, the default notification stubs (
notification.stub
andmarkdown-notification.stub
) include theIlluminate\Bus\Queueable
trait by default.However, the
Illuminate\Bus\Queueable
trait is only actually needed if the notification implementsShouldQueue
interface, because otherwise Laravel sends notifications immediately using thesendNow
method, which doesn’t use the queue-related properties likeconnection
orqueue
from theIlluminate\Bus\Queueable
trait.Here's a reference in https://github.com/laravel/framework/blob/12.x/src/Illuminate/Notifications/NotificationSender.php:
What This PR Changes:
queueable
trait andShouldQueue
interface from the default stubsqueueable
trait andShouldQueue
interfacemake:notification
Artisan command to use--queued
flag