Skip to content

[12.x] Class uses recursive #56079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: 12.x
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@
use Illuminate\Support\Facades\Facade;
use Illuminate\Support\Facades\ParallelTesting;
use Illuminate\Support\Once;
use Illuminate\Support\Reflector;
use Illuminate\Support\Sleep;
use Illuminate\Support\Str;
use Illuminate\View\Component;
Expand Down Expand Up @@ -181,6 +182,7 @@ protected function tearDownTheTestEnvironment(): void
Once::flush();
PreventRequestsDuringMaintenance::flushState();
Queue::createPayloadUsing(null);
Reflector::flushState();
RegisterProviders::flushState();
Sleep::fake(false);
TrimStrings::flushState();
Expand Down
37 changes: 37 additions & 0 deletions src/Illuminate/Support/Reflector.php
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,43 @@

class Reflector
{
private static array $classesUsesRecursive = [];
Copy link
Contributor

@cosmastech cosmastech Jun 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think of Laravel/package code uses protected to allow for extension.

Suggested change
private static array $classesUsesRecursive = [];
/**
* @var array<class-string, list<class-string>>
*/
protected static array $classesUsesRecursive = [];


/**
* Returns all traits used by a class, its parent classes and trait of their traits.
*
* @param object|string $class
* @return array
*/
public static function classUsesRecursive(object|string $class)
{
if (is_object($class)) {
$class = get_class($class);
}

if (! isset(self::$classesUsesRecursive[$class])) {
$results = [];

foreach (array_reverse(class_parents($class) ?: []) + [$class => $class] as $class) {
$results += trait_uses_recursive($class);
}

self::$classesUsesRecursive[$class] = array_unique($results);
}

return self::$classesUsesRecursive[$class];
}

/**
* Flush the component's cached state..
*
* @return void
*/
public static function flushState()
{
static::$classesUsesRecursive = [];
}

/**
* This is a PHP 7.4 compatible implementation of is_callable.
*
Expand Down
12 changes: 1 addition & 11 deletions src/Illuminate/Support/helpers.php
Original file line number Diff line number Diff line change
Expand Up @@ -102,17 +102,7 @@ function class_basename($class)
*/
function class_uses_recursive($class)
{
if (is_object($class)) {
$class = get_class($class);
}

$results = [];

foreach (array_reverse(class_parents($class) ?: []) + [$class => $class] as $class) {
$results += trait_uses_recursive($class);
}

return array_unique($results);
return \Illuminate\Support\Reflector::classUsesRecursive($class);
}
}

Expand Down