[12.x] Ensure cookie lifetime matches session lifetime in StartSession middleware #57266
+3
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n middleware Updated getCookieExpirationDate() to use getSessionLifetimeInSeconds() instead of directly accessing the lifetime config, ensuring consistency between session and cookie expiration times.
michaelcontento
deleted the
cookie_lifetime_should_match_session_lifetime
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated
getCookieExpirationDate()inIlluminate\Session\Middleware\StartSessionto usegetSessionLifetimeInSeconds()instead of directly accessing thelifetimeconfig, ensuring consistency between session and cookie expiration times.Context
Discovered this while working with a custom middleware extending
StartSessionthat overridesgetSessionLifetimeInSeconds(). Cookie lifetime wasn't respecting the override (expected behavior), as it was reading directly from config instead.Tests
No new tests added yet - waiting for feedback first in case the current behavior is intentional. Happy to add tests if the change is acceptable.