[12.x] Add Stringable::doesntContain() to match API symmetry #57279
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds the missing doesntContain() method to the Stringable class to provide symmetry with the contains() method. The method proxies to the existing Str::doesntContain() implementation.
Tests cover all parameter combinations including arrays, collections, case sensitivity, and edge cases. All tests pass successfully.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the missing
doesntContain()method to theStringableclass to provide symmetry with the existingcontains()method.Changes
Stringable::doesntContain($needles, $ignoreCase = false)methodStr::doesntContain()implementationMotivation
Currently,
Stringablehas acontains()method but lacks the correspondingdoesntContain()method, whileStrhas both. This creates an API inconsistency where developers expect both methods to be available in the fluent interface.