Skip to content

Conversation

MadBox-99
Copy link
Contributor

@MadBox-99 MadBox-99 commented Oct 8, 2025

in return documentation order is factory, then ViewContract and IDE is showing diferent order, this is so confusing when hower over the method

in return documentation order is factory then ViewContract and IDE is showin diferent order this is so confusing when hower over the method
@Copilot Copilot AI review requested due to automatic review settings October 8, 2025 09:25
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Fixes the order of return types in the view() function signature to match the documentation order. The return type annotation was changed from ViewContract|ViewFactory to ViewFactory|ViewContract to align with the PHPDoc comment that specifies factory first, then ViewContract.

  • Reordered union types in function signature to match documentation order

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@shaedrich
Copy link
Contributor

Does this happen in every IDE or is this an IDE-specific thing?

@MadBox-99
Copy link
Contributor Author

MadBox-99 commented Oct 8, 2025

its happend in VSCode with
PHP Intelephense extension
by: Ben Mewburn, intelephense.com
this image is how Abc and docs order, in second pic is actual version in 12.x, my change is fix this
Képernyőfotó 2025-10-08 - 11 30 48

Képernyőfotó 2025-10-08 - 11 36 11

Current version(Bad order):
Képernyőfotó 2025-10-08 - 11 44 32

@shaedrich
Copy link
Contributor

"Fixing" is a bit of a strong word for something that isn't "broken", just not that easy on the eye for some that look closely

@taylorotwell taylorotwell merged commit cefbf21 into laravel:12.x Oct 8, 2025
66 checks passed
@MadBox-99 MadBox-99 deleted the patch-1 branch October 8, 2025 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants