Skip to content

Conversation

avosalmon
Copy link
Contributor

Fixes #57246.

On the local exception page, syntax-highlighted queries are not properly truncated and overflow the row when the query contains newlines.

Before

CleanShot 2025-10-09 at 14 59 29

After

CleanShot 2025-10-09 at 14 58 41

Comment on lines -66 to -68
code(node) {
this.addClassToHast(node, 'flex flex-col');
},
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This breaks text truncation.

@avosalmon avosalmon marked this pull request as ready for review October 9, 2025 06:07
@avosalmon avosalmon changed the title [12.x] Fix text truncation on syntax-highlighted code [12.x] Fix text truncation on syntax-highlighted queries Oct 9, 2025
pull_request:
paths:
- 'src/Illuminate/Foundation/resources/exceptions/renderer/**'
- '!src/Illuminate/Foundation/resources/exceptions/renderer/dist/**'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automatically builds assets on PR.

@taylorotwell taylorotwell merged commit f2396a7 into 12.x Oct 9, 2025
66 checks passed
@taylorotwell taylorotwell deleted the truncate-syntax-highlighted-text branch October 9, 2025 14:51
amirhshokri pushed a commit to amirhshokri/laravel-framework that referenced this pull request Oct 9, 2025
* Fix text truncation for syntax highlighted code

* Update assets on pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

New lines in querys in exception page breaks frontend and built-in syntax on the page

2 participants