[5.0] Normalize view names with namespaces with slashes properly

[anlutro]

Had to move const HINT_PATH_DELIMITER to the ViewFinderInterface. static::HINT_PATH_DELIMITER in classes implementing the interface still works. http://3v4l.org/Z616Z

This does prevent end users from defining their own namespace delimiter. We could make a method ViewFinderInterface->getDelimiter() method instead. Thoughts?

Ref #5756 (comment)

[crynobone]

We could make a method ViewFinderInterface->getDelimiter() method instead. Thoughts?

I don't see much advantage on allowing it to be configurable. From a package developer perspective, we already following the default :: convention, and if app developer modify this, it would still break package code.

[anlutro]

Good point, I agree.

[jasonlewis]

How often is it used? Even worth having it as a constant?

[anlutro]

Well, both the View\Factory and FileViewFinder need to know about it, so a constant does make sense as it's easily shared between the two.

[jasonlewis]

I figured since it can't be changed why not hard code it in. What's the benefits of keeping it as a constant? Only thing I can think of is if someone were to implement their own finder and they want to use the constant in case it were to ever change, for whatever reason.

[jasonlewis]

I'll beat our man @GrahamCampbell to it. No need for the spaces when concatenating. 👼

[anlutro]

Constants are great, man. Even if in theory '::' for view namespace delimiters will never be changed to something else, having it defined in one place and one place only eases my mind - I don't like writing code that requires a search/replace to change something later on.

[GrahamCampbell]

👍

[patrickheeney]

This is nice. Could this be done to anything that uses namespaces: configs and lang?

[anlutro]

I don't think so, because in config/lang files there can be multidimensional arrays. For example... Config::get('one/two.three.four') will open the file config/one/two.php and look for the array key ['three']['four']. If you replace the / with a . or vice-versa you get completely different behaviour.

[anlutro]

This is also why I'd prefer slashes over dots - it's more consistent with config/lang file behaviour.

[patrickheeney]

EDIT: Disregard, I see you don't normalize the namespace with dots.

This would be for the namespace for consistency. Config::get('project.namespace::one/two.three.four'). I agree with the later part though, it would be difficult for folder behavior with the dot notation. With this change merged, I would suspect the namespaces to work the same everywhere.