Adding missing guest method to Authentificator interface
#5939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Within `auth` filter provided with `laravel/laravel` the `guest` method of `Authentificator` interface is used. For now the `Guard` class implementing that interface has that method, but interface itself doesn't.
taylorotwell
added a commit
that referenced
this pull request
Oct 2, 2014
Adding missing `guest` method to `Authentificator` interface
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Within
authfilter provided withlaravel/laraveltheguestmethod ofAuthentificatorinterface is used (see https://github.com/laravel/laravel/blob/develop/app/Http/Filters/AuthFilter.php#L47). For now theGuardclass implementing that interface has that method (see https://github.com/laravel/framework/blob/master/src/Illuminate/Auth/Guard.php#L115), but interface itself doesn't.If anybody would need to implement their own authentification just based on interface then they will get Fatal Error because
guestmethod would be called no matter what regardless of what interface says.