Use timing safe string comparison in CSRF filter #6385
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use a timing safe comparison, as provided by the Symfony Security Component.
barryvdh
referenced
this pull request
in laravel/laravel
Nov 11, 2014
taylorotwell
added a commit
that referenced
this pull request
Nov 11, 2014
Use timing safe string comparison in CSRF filter
|
We need to depend on the security component in the http composer.json now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use a timing safe comparison, as provided by the Symfony Security Component.
As proposed by by @lasselehtinen and @ircmaxell in ba0cf2a
See also laravel/laravel#3126