[5.0] Make Use of firstByAttributes and Expose it Publicly #7300
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Small refactor to actually use `firstByAttributes` *(it is not currently used anywhere in the framework)* and expose the method publicly as another available finder.
deefour
changed the title
deefour
changed the title
|
On the contrary, this method should have really been deleted for L5. It was originally created before we got support for array wheres. Now it's just useless cruft. Compare the two: $user = User::where($attributes)->first();
$user = User::firstByAttributes($attributes);The first line is both shorter and more readable. |
|
Great, thanks for clarifying. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small refactor to actually use
firstByAttributes(it is not currently used anywhere in the framework) and expose the method publicly as another available finder.