Allow both encrypted + unencrypted CSRF header token - #7528
Merged
Conversation
Contributor
|
Now this seems like a proper universal fix. Clears up the apparently unknown convention of XSRF vs. CSRF. |
Contributor
Author
|
Well I don't know if that is really the convention. I think the token being encrypted is more of a side-effect of laravel's cookies always being encrypted, which just doesn't matter for Angular bot does for other ways to pass the token. |
taylorotwell
added a commit
that referenced
this pull request
Feb 20, 2015
Allow both encrypted + unencrypted CSRF header token
Member
|
Can you submit a documentation PR? |
barryvdh
added a commit
to barryvdh/docs
that referenced
this pull request
Feb 20, 2015
Contributor
Author
|
Docs PR in laravel/docs#1179 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I know something similar has been submitted before, but currently CSRF works for these situations:
But it doesn't for other common use-cases:
Proposal: Also check the X-CSRF-TOKEN header for plain-text token. This make it easier to add a meta-tag to the page which javascript checks.
<meta name="csrf-token" content="<?= csrf_token ?>" />Some frameworks/scripts already use this convention. like Jquery UJS
We see a lot of issues by people not understaning the decryption or need to remove it. This will allow all cases:
And a section would needed to be added to the docs, but I'm willing to write that, with a few simple examples.
Fixes #7418 #7437 #7436 #7373 #7435 #7288 #7287