Changes made to support php artisan schedule:run on windows

[uwascan]

Changes made to src/Illuminate/Console/Scheduling/Event.php to support 'php artisan schedule:run > NUL 2>&1 &' on windows since '/dev/null' does not exist in windows environment.

[uwascan]

php artisan schedule:run > /dev/null 2>&1 &
results in 'The system cannot find the path specified.' error on windows 7

[franzliedke]

You can turn this into a one-liner like this:

return strncasecmp(PHP_OS, 'WIN', 3) == 0;

[neomerx]

@uwascan @franzliedke 👎 as for PHP_OS constant keep in mind this constant will contain the operating system PHP was built on but not it runs on

[neomerx]

@uwascan sudo for windows might look like $this->user ? 'runas /noprofile /user:'.$this->user.' '.$command : $command;

[neomerx]

@uwascan $this->output might need more attention
it's declared like

protected $output = '/dev/null';

and looks to be never changed.
It could be set correctly in constructor however it's needed to be considered that it's used in a couple of places like this

if (is_null($this->output) || $this->output == '/dev/null')
{
    ...
}

In such places it might require to change to something like

if (is_null($this->output) || $this->isOutputToNull())
{
    ...
}

with platform dependent implementation

[neomerx]

@uwascan You're one of the few lucky windows users :) as it requires more that just a couple of lines I would suggest asking @taylorotwell or/and @GrahamCampbell if they accept such changes.
Would be frustrating if they reject supporting it when all is done.

[ghost]

To add to the above you need to use tabs, not spaces.

[RomainLanz]

Remove this file from your PR.

[GrahamCampbell]

Please fix the total cs mess.

[uwascan]

Thank you all for your contributions. I realize now that I need to follow Laravel coding standards next time. I will clean up the code and try again. That was my first PR ever, imagine the excitement.
Laravel for Life!!!

[uwascan]

Another simple way to make this work on windows without changing Laravel code is to append the following to your sheduler code

->sendOutputTo('NUL')

Example

$schedule->command('inspire')->cron('*/1 * * * * *') ->sendOutputTo('NUL');

the code below works on windows when sending output to a file.

$schedule->command('inspire')
        ->cron('*/1 * * * * *') ->sendOutputTo(storage_path('logs/output.log'));

This is what I am currently using (with a windows based cron service [http://www.intelliadmin.com/index.php/2011/11/cron-service-for-windows/]) and all is good so far. I think this should be added to the docs.

[barryvdh]

Or use Symfony Process with disableOutput()? http://symfony.com/doc/current/components/process.html#disabling-output
Or look at how they do it perhaps.