Skip to content

[5.1] Change default fetch mode to FETCH_OBJ #8141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 25, 2015
Merged

[5.1] Change default fetch mode to FETCH_OBJ #8141

merged 2 commits into from
Mar 25, 2015

Conversation

franzliedke
Copy link
Contributor

Let's at least unify the default config setting in v5.1 so that both the standalone component and Laravel's base use FETCH_CLASS by default.

See #8107
/ping @jchamberlain

@jchamberlain
Copy link
Contributor

Totally agree. That said, could you do FETCH_OBJ instead of FETCH_CLASS? It's a minor difference, but that was a small point of confusion for me when I first started using Laravel. (See http://php.net/manual/en/pdostatement.fetch.php.)

@franzliedke
Copy link
Contributor Author

@jchamberlain Thanks, done.

@GrahamCampbell GrahamCampbell changed the title [5.1] Change default fetch mode to FETCH_CLASS [5.1] Change default fetch mode to FETCH_OBJ Mar 25, 2015
taylorotwell added a commit that referenced this pull request Mar 25, 2015
@taylorotwell
Merge pull request #8141 from franzliedke/unify-fetch-mode
ee9ebc8 
[5.1] Change default fetch mode to FETCH_OBJ
@taylorotwell taylorotwell merged commit ee9ebc8 into laravel:master Mar 25, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@franzliedke @jchamberlain @taylorotwell