currency() callback support

[chimit]

• Laravel Version: 9.21.6
• Nova Version: 4.12.12
• PHP Version: 8.1.7
• Operating System and Version: macOS Monterey 12.4
• Browser type and version: Safari macOS

Description:

I can't specify the currency that is taken from a relationship:

Currency::make('Monthly price', function () {
    return $this->prices()->monthly()->first()->amount;
})
    ->currency($this->prices()->monthly()->first()->currency),

Possible solution is to make currency() method accept callbacks. Currently, it only supports strings. Or, please, let me know if there are other ways to get it.

[crynobone]

You can try:

Currency::make('Monthly Price')
    ->tap(function ($field) {
        $price = $this->prices()->monthly()->first();

        $field->resolveUsing(function () use ($price) {
            return $price->amount;
        })->currency($price->currency);
    })->exceptOnForms(),

[crynobone]

Currency::make('Monthly price')
    ->tap(function ($field) {
        $price = $this->prices()->monthly()->first();

        $field->resolveUsing(function () use ($price) {
            return optional($price)->amount;
        })
        
        if (!is_null($price)) {
            $field->displayUsing(function () use ($field, $price) {
                return $field->formatMoney($price->amount);
            })->currency($price->currency);
        }
    })->exceptOnForms(),

[chimit]

Thanks! It works for the view page, but not for the index.

I think making currency() accept closures would still be a cleaner way (or somehow pass the currency from make()). So far I would instead use this simple approach:

Text::make('Monthly price', function () {
    $price = $this->prices()->monthly()->first();

    return $price
        ? $price->currency . ' ' . number_format($price->amount)
        : null;
}),

[juse-less]

Pre-post: Darnit. It was resolved as I wrote below. >.<

I've had a lot of issues with this in the past and had to fallback to using a Number field and not display currency.
Now that I tried with the info that @crynobone gave above, it went smooth.
I've tried similar things before, so not sure what I did wrong (albeit, I wasn't using tap()).

In my case, though, all I needed to do was to check for is if the value/relation in the chain of calls was null.
I have an invoice that the currency is on, and the prices per line item where I want to display it.
It was failing on index views, but works with the snippet below (could've sworn I tried it in the past) -

// Invoice Line Item
Currency::make(__('Unit Price'), attribute: 'unit_price')
    ->currency($this->invoice?->currency)
    ->sortable(),

Currency::make(__('Amount'), attribute: 'amount')
    ->currency($this->invoice?->currency)
    ->sortable(),

So you should be able to use something like the snippets from above.

[chimit]

What the... it works 😄

Currency::make('Monthly price', function () {
    return $this->prices()->monthly()->first()?->amount;
})
    ->currency($this->prices()->monthly()->first()?->currency),

[juse-less]

I'd recommend calling it above the array, so you don't make duplicate database requests, though.

public function fields()
{
    $monthlyPrice = $this->prices()->monthly()->first();

    return [
        Currency::make('Monthly price', fn () => $monthlyPrice?->amount)
            ->currency($monthlyPrice?->currency),
    ];
}