[1.x] Improve migration errors to guide developers with unsupported drivers #233
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timacdonald
force-pushed
the
migrations
branch
7 times, most recently
from
7dca36e to
56f917c
Compare
timacdonald
force-pushed
the
migrations
branch
from
56f917c to
3c43927
Compare
|
I think we should revert laravel/laravel@4705136 after this is merged, but again, not a hill I'm gonna die on. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
phpunit+sqlite+PULSE_ENABLED=falseDatabase migrations are ignored ✅
phpunit+sqlite+PULSE_ENABLED=trueThrows an exception pointing developer to disable pulse if they want to.
artisan migrate+sqlite+PULSE_ENABLED=trueThrows an exception indicating that the DB is not supported.
artisan migration+sqlite+PULSE_ENABLED=falseThrows an exception indicating that the DB is not supported. This is important because we don't want to record in the migrations table that the migration has been run, because enabling pulse later will not work.