Skip to content

Conversation

toitzi
Copy link
Contributor

@toitzi toitzi commented Dec 1, 2023

Similiar to other first pary packages i thought it would be great to allow ignoring route registration, in order to be able to register the routes yourself. A more practical use case might be if you use something like tenancy for laravel where registring the routes only on central domains, etc.. can be beneficial and easir to be created that way

@jessarcher jessarcher self-requested a review December 2, 2023 06:40
@jessarcher jessarcher self-assigned this Dec 2, 2023
@timacdonald timacdonald changed the title Allow ignoring route registration [1.x] Allow ignoring route registration Dec 3, 2023
Copy link
Member

@timacdonald timacdonald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on a fresh application and a real application. Works as expected.

Only caveat is that this would generally need to be done in the service provider's register method, not it's boot method.

@taylorotwell
Copy link
Member

Has conflicts.

@taylorotwell taylorotwell marked this pull request as draft December 4, 2023 19:26
@toitzi
Copy link
Contributor Author

toitzi commented Dec 4, 2023

Has conflicts.

Resolved, there seems to be an issue with the static code analysis from the 1.x branch right now

Signed-off-by: Tobias Oitzinger <tobiasoitzinger@gmail.com>
@timacdonald timacdonald marked this pull request as ready for review December 5, 2023 04:55
@timacdonald
Copy link
Member

rebased this one against a fix version

@taylorotwell taylorotwell merged commit 889bb44 into laravel:1.x Dec 5, 2023
greatislander added a commit to accessibility-exchange/platform that referenced this pull request Jul 15, 2025
greatislander added a commit to accessibility-exchange/platform that referenced this pull request Jul 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants