Skip to content

Fix n plus query issue with likes #1345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 3, 2025
Merged

Fix n plus query issue with likes #1345

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/Livewire/Likes.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ public function mount($subject): void

public function getLikers(): array
{
$likers = $this->subject->likersRelation()->limit($this->limit + 1)->pluck('username')->toArray();
$likers = $this->subject->likes()->slice($this->limit + 1)->pluck('username')->toArray();

if (auth()->check() && in_array($authUsername = auth()->user()->username, $likers)) {
$likers = array_diff($likers, [$authUsername]);
Expand Down
5 changes: 1 addition & 4 deletions app/Models/Thread.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -294,10 +294,7 @@ public static function feedByTagQuery(Tag $tag): Builder
*/
public static function feedQuery(): Builder
{
return self::withOnly([
'tagsRelation',
'authorRelation',
])
return self::query()
->withCount(['repliesRelation as reply_count', 'likesRelation as like_count'])
->latest('last_activity_at');
}
Expand Down
1 change: 1 addition & 0 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@
"symfony/mailgun-mailer": "^7.0"
},
"require-dev": {
"barryvdh/laravel-debugbar": "^3.16",
"fakerphp/faker": "^1.23",
"mockery/mockery": "^1.6",
"nunomaduro/collision": "^8.0",
Expand Down
160 changes: 159 additions & 1 deletion composer.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.