Skip to content

Conversation

mr-chok
Copy link
Contributor

@mr-chok mr-chok commented Sep 12, 2025

Solves #688

  • Added a new user field: has_identicon, calculated through an async job dispatched at user signup.
  • Used has_identicon field in the avatar component to decide the picture to be shown.
    Note: The only existing GitHub test (GitHubUserTest.php) doesn’t cover HTTP requests. My contribution depends on the HTTP client bootstrap, so adding tests would require extra Pest setup I wasn’t sure to include.

Final view of some users created through the local tests:
image

@driesvints driesvints merged commit efd1f1b into laravelio:main Sep 12, 2025
1 check passed
@driesvints
Copy link
Member

Thanks a lot for this one! Gonna try out the backfill of identicons in a bit.

@driesvints
Copy link
Member

The logic here was incorrect:

return ! ($width === 420 && $height === 420);

Should have been:

return $width === 420 && $height === 420;

It's fine, I'm gonna re-run the backfill.

Copy link

sentry-io bot commented Sep 12, 2025

Issues attributed to commits in this pull request

This pull request was merged and Sentry observed the following issues:

Did you find this useful? React with a 👍 or 👎

@driesvints
Copy link
Member

The queue is still going but starting to look pretty good. Identicons on the homepage are starting to disappear 🥳

Thanks!

@mr-chok
Copy link
Contributor Author

mr-chok commented Sep 12, 2025

Sorry and thanks about the returning logic, I may have passed that when rebasing.
Happy to help! 🙌🏽

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants