Skip to content

Prevented current article showing in trending articles section #687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 27, 2021

Conversation

ash-jc-allen
Copy link
Contributor

Hey!

This PRs only a small one, but it updates something that I just noticed while on the site.

Say if you go to an article, such as https://laravel.io/articles/using-database-transactions-to-write-safer-laravel-code, when you scroll to the bottom to the "Other articles you might like" section, the current article is in the list (the screenshot shows this).

I know that this isn't really a big issue and is probably unlikely to happen often. But, I've made a small PR which should prevent it in the future.

If this is something you might want to pull in, let me know if there are any changes I need to make 😄

Screenshot 2021-09-27 at 15 24 43

Copy link
Member

@driesvints driesvints left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ash-jc-allen. Just a minor change here.

@driesvints driesvints merged commit d72a070 into laravelio:main Sep 27, 2021
@driesvints
Copy link
Member

Thanks!

@ash-jc-allen ash-jc-allen deleted the trending-articles-change branch September 27, 2021 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants