Skip to content

Conversation

digitlimit
Copy link
Contributor

@digitlimit digitlimit commented Dec 13, 2023

What does this PR do and why

  • Add a command for removing duplicate GitHub usernames
  • Implement duplicate checks for sign-in and signup

Commands

php artisan lio:remove-duplicate-github-usernames

Config

Generate Github API Token Personal access tokens (classic)

Screenshots or screen recordings

Closes #658

@digitlimit digitlimit changed the title Unique GitHub Usernames Unique GitHub Usernames - WIP Dec 13, 2023
@digitlimit digitlimit marked this pull request as draft December 14, 2023 00:05
@digitlimit digitlimit changed the title Unique GitHub Usernames - WIP Unique GitHub Usernames Jan 13, 2024
@digitlimit digitlimit marked this pull request as ready for review January 31, 2024 22:08
Copy link
Member

@driesvints driesvints left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heya! Sorry it took me this long to get back here. Left some feedback on the PR.

@digitlimit digitlimit force-pushed the feat/unique-github-usernames branch 2 times, most recently from 0de084b to 5c2f04a Compare February 24, 2024 13:13
@digitlimit digitlimit marked this pull request as draft February 25, 2024 18:44
@digitlimit digitlimit force-pushed the feat/unique-github-usernames branch from 5c2f04a to fec519a Compare February 25, 2024 20:15
@digitlimit digitlimit marked this pull request as ready for review February 26, 2024 19:15
@driesvints driesvints merged commit 7b24ffe into laravelio:main Feb 28, 2024
@driesvints
Copy link
Member

Thanks for this one! Had to remove a few manually but other than that it went smooth.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

GitHub usernames should be unique
2 participants