Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make gctwa O(n) instead of O(n^2) #811

Merged
merged 1 commit into from
Jul 20, 2017
Merged

Make gctwa O(n) instead of O(n^2) #811

merged 1 commit into from
Jul 20, 2017

Conversation

lars-t-hansen
Copy link
Member

This is much faster and I think it's still correct. With 200000 dead symbols on the oblist it runs in 90ms instead of 40s on my MacBook Pro.

It's ugly that it writes the proplists of candidate symbols while it's running; to do better we would use a separate hash table.

@WillClinger
Copy link
Member

Thank you, Lars. Later today, when I have more time, I will accept this pull request and then simplify it a bit.

@lars-t-hansen
Copy link
Member Author

lars-t-hansen commented Jul 20, 2017 via email

@WillClinger WillClinger merged commit 1a06296 into master Jul 20, 2017
@lars-t-hansen lars-t-hansen deleted the gctwa-faster branch July 22, 2017 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants