Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"User must be logged in" - while commenting #138

Closed
treygriffith opened this issue Feb 11, 2014 · 3 comments
Closed

"User must be logged in" - while commenting #138

treygriffith opened this issue Feb 11, 2014 · 3 comments

Comments

@treygriffith
Copy link
Collaborator

I keep getting an error while trying to comment on different news stories (while logged in).

I've tried logging out and back in, and commenting on different stories, all with the same result.

@megamattron
Copy link
Member

Must have gotten broken in one of the comment related pull requests, I think I've fixed it. Hopefully!

@treygriffith
Copy link
Collaborator Author

Just tried it and it worked, although does that mean that non-logged-in
users will be able to post comments?

On Tue, Feb 11, 2014 at 6:32 PM, Matt Hall notifications@github.com wrote:

Must have gotten broken in one of the comment related pull requests, I
think I've fixed it. Hopefully!

Reply to this email directly or view it on GitHubhttps://github.com//issues/138#issuecomment-34832936
.

@megamattron
Copy link
Member

I don't think so, but someone should check my commit. I moved authentication requirement into the app.js controller mapping.

On Feb 11, 2014, at 9:34 PM, Trey Griffith notifications@github.com wrote:

Just tried it and it worked, although does that mean that non-logged-in
users will be able to post comments?

On Tue, Feb 11, 2014 at 6:32 PM, Matt Hall notifications@github.com wrote:

Must have gotten broken in one of the comment related pull requests, I
think I've fixed it. Hopefully!

Reply to this email directly or view it on GitHubhttps://github.com//issues/138#issuecomment-34832936
.


Reply to this email directly or view it on GitHub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants