adding item created to the table #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I wanted to see when the listing was created so I added another column to hold the item.created value seen in NewsItem schema
|
Sweet, add your username to the userlist file too and update the PR and I'll try to merge. More details here: http://pullup.herokuapp.com/signup |
barretts
added a commit
to barretts/pullup
that referenced
this pull request
Feb 7, 2014
Added user name in connection with pull request larvalabs#34
|
Sorry I think I ended up making another pull request. My first pull request experience! Sent from Windows Mail From: Matt Hall Sweet, add your username to the userlist file too and update the PR and I'll try to merge. More details here: http://pullup.herokuapp.com/signup — |
megamattron
pushed a commit
that referenced
this pull request
Feb 7, 2014
|
Ok I merged this, but I switch to showing "timeago" notation which is a little easier to read. We might want to move or deprioritize the placement too, but it's in there for now. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to see when the listing was created so I added another column to hold the item.created value seen in NewsItem schema