Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add good ol' bender #5

Closed
wants to merge 1 commit into from
Closed

Conversation

RobertLowe
Copy link

Am I doing this right? 👍

@megamattron
Copy link
Member

Would you mind rebasing (or just merging from parent again), we've added a user to the list since you forked. Also maybe we need to think of a way to add users that will be easier to merge or won't conflict @pents90

@RobertLowe
Copy link
Author

Yea, nope.

Perhaps users could add a file with there username instead. In say a users folder.

@megamattron
Copy link
Member

Oh yeah, maybe something like that would be better.

@RobertLowe
Copy link
Author

I'm not sure how it will scale, but I'd bet caching/load-once the list of names will be fine for a while & avoid conflicts.

@megamattron
Copy link
Member

Hey Robert, there's a discussion of minimum standards for an accepted PR over at #61 - is there anything you want to add feature wise? I'll close in the meantime to keep the PR queue semi-clean. Thanks!

@megamattron megamattron closed this Feb 7, 2014
@RobertLowe
Copy link
Author

@megamattron that's fine, grats on all the pulls. nothing to add right now.

@megamattron
Copy link
Member

Ok, thanks. Hope you think of something :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants