Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Comments to News Stories #73

Merged
merged 17 commits into from
Feb 9, 2014
Merged

Conversation

treygriffith
Copy link
Collaborator

It's very ugly, and there is no voting on comments, or any sort of other information you might want to have, but it works. This should address #63.

@megamattron
Copy link
Member

Awesome! There's a small conflict in news.js now because vote based sorting was added in the interim, I'm not quite sure how best to resolve. Could you rebase and take a look?

@treygriffith
Copy link
Collaborator Author

@megamattron Should be all set now. One important note: I changed the Vote model to be generalized so that it can eventually be used for comment voting. That means the model itself no longer refs the NewsItem model, and if you want to populate, you'll have to specify which model to populate from using the new mandatory itemType property as guidance.

@megamattron megamattron merged commit 8898b90 into larvalabs:master Feb 9, 2014
@megamattron
Copy link
Member

Awesome, merged and released. Can't believe we have comments already.

@megamattron megamattron mentioned this pull request Feb 9, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants