-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Option in setup/settings to choose between mm/s and mm/min #55
Labels
Comments
ghost
added
the
feature request
label
Dec 8, 2016
jorgerobles
added a commit
that referenced
this issue
Dec 11, 2016
jorgerobles
added a commit
that referenced
this issue
Dec 11, 2016
@cojarbi Setting is stored, now needs propagation. |
jorgerobles
added a commit
that referenced
this issue
Dec 11, 2016
tbfleming
pushed a commit
that referenced
this issue
Dec 11, 2016
It's now in place, but has a bug. If the setting is empty, the CAM assumes mm/min since that's what gcode normally is. The settings UI shows mm/s when the setting's empty. |
jorgerobles
added a commit
to jorgerobles/LaserWeb4
that referenced
this issue
Dec 11, 2016
Changed to react-select and pick default value (mm/min) if none exists
2016-12-11 18:47 GMT+01:00 Todd Fleming <notifications@github.com>:
… It's now in place, but has a bug. If the setting is empty, the CAM assumes
mm/min since that's what gcode normally is. The settings UI shows mm/s when
the setting's empty.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#55 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABoIYJ9Vq17YWvYFEcsWJqaDLk5DDLuGks5rHDcWgaJpZM4LHxPP>
.
|
Overlooked. sorry :|
2016-12-11 20:07 GMT+01:00 Todd Fleming <notifications@github.com>:
… react-select gives you an object; you need to get just the value from it.
[image: image]
<https://cloud.githubusercontent.com/assets/418464/21082520/03c5b09c-bfab-11e6-8171-522af9f51cbc.png>
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#55 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABoIYKDq568iDQgK8I124a9EdtJnbQvxks5rHEoPgaJpZM4LHxPP>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Its simple math but have the option to choose either make it more comfortable
The text was updated successfully, but these errors were encountered: