Add several test related things #10
Conversation
Fix all lint warnings
Use latest OTP19.3 for Travis builds
|
Can you explain the change regarding the eager push list? |
|
Sure, when i added the tests, specifically the connectedness check, i found that some times (not all) plumtree would not have a fully connected graph (considering both eager and lazy lists), this happened more often on 4-node clusters. I'm thinking this is a remnant of the basho fork (that was manually building the spanning tree) and does not make sense anymore now that the |
|
Can you remove some of the debug logging? That's going to cause a significant performance hit if the code is executed often. (Unfortunately, even with a higher/lower log level, the debug code still gets dispatched.) |
|
maybe have a switch to turn it on/off then? it's really hard tracking down anything in this without some logging |
|
I've reworked it so now there's only debug when running tests |
Declare a broadcast handler and using different partisan managers test different configurations under the same scenario: create a cluster, do several rounds of broadcast on random nodes, finally make one broadcast and ensure it reaches the entire membership.
Instead of relying on a custom built tree use the membership provided by partisan. Directly add new members to the eager push list as per the paper.
linting, coverage, eunit tests, common tests
Also, do away with the custom tree calculation of the eager push list, use whatever the peer service gives us