make #[derive(sqlx::Type)] automatically generate impl PgHasArrayType by default for newtype structs
#4008
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ype` by default for newtype structs add regression tests
|
Other than enums, I don't know of any other cases that can be "wrapped" by a domain type. If desired, I can create a test for those as well. |
JosiahParry
pushed a commit
to JosiahParry/sqlx
that referenced
this pull request
Sep 24, 2025
…ype` by default for newtype structs (launchbadge#4008) add regression tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does your PR solve an issue?
fixes #3996
See the issue for the reasoning behind the changes.
Is this a breaking change?
Yes. People who use domain types in PostgreSQL have likely already implemented the
PgHasArrayTypetrait manually to work around the problem from #3996. In that case, my changes would introduce a duplicate implementation of the trait. The solution would be to either remove the manual implementation or add the#[sqlx(no_pg_array)]attribute to the struct.