fix: more helpful error messages for streaming connection failures #419
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwaldren-ld
force-pushed
the
cw/sc-246253/better-sse-error-messages
branch
from
0930d56 to
2b379f3
Compare
kinyoklion
reviewed
Jul 11, 2024
|
|
||
| if (status_class == beast::http::status_class::client_error) { | ||
| if (recoverable_client_error(response.result())) { | ||
| return async_backoff(backoff_reason(response.result())); |
There was a problem hiding this comment.
When does this get logged and what does it look like if it is?
There was a problem hiding this comment.
It's what happens when there's a "recoverable" client error and a retry will occur. The log message looks like:
"Backing off in (N) seconds due to HTTP status 403 (Forbidden)"
kinyoklion
approved these changes
Jul 15, 2024
Merged
cwaldren-ld
pushed a commit
that referenced
this pull request
Jul 15, 2024
🤖 I have created a release *beep* *boop* --- <details><summary>launchdarkly-cpp-client: 3.6.2</summary> ## [3.6.2](launchdarkly-cpp-client-v3.6.1...launchdarkly-cpp-client-v3.6.2) (2024-07-15) ### Bug Fixes * more helpful error messages for streaming connection failures ([#419](#419)) ([6bd21ba](6bd21ba)) ### Dependencies * The following workspace dependencies were updated * dependencies * launchdarkly-cpp-sse-client bumped from 0.5.0 to 0.5.1 </details> <details><summary>launchdarkly-cpp-server: 3.5.2</summary> ## [3.5.2](launchdarkly-cpp-server-v3.5.1...launchdarkly-cpp-server-v3.5.2) (2024-07-15) ### Bug Fixes * more helpful error messages for streaming connection failures ([#419](#419)) ([6bd21ba](6bd21ba)) ### Dependencies * The following workspace dependencies were updated * dependencies * launchdarkly-cpp-sse-client bumped from 0.5.0 to 0.5.1 </details> <details><summary>launchdarkly-cpp-server-redis-source: 2.1.10</summary> ## [2.1.10](launchdarkly-cpp-server-redis-source-v2.1.9...launchdarkly-cpp-server-redis-source-v2.1.10) (2024-07-15) ### Dependencies * The following workspace dependencies were updated * dependencies * launchdarkly-cpp-server bumped from 3.5.1 to 3.5.2 </details> <details><summary>launchdarkly-cpp-sse-client: 0.5.1</summary> ## [0.5.1](launchdarkly-cpp-sse-client-v0.5.0...launchdarkly-cpp-sse-client-v0.5.1) (2024-07-15) ### Bug Fixes * more helpful error messages for streaming connection failures ([#419](#419)) ([6bd21ba](6bd21ba)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit pulls the stringification logic of SSE errors into the SSE package itself, and refactors the enum into a richer sum type using
std::variant.